Prevent merge from crashing with a WindowsPath serialization error#4271
Merged
blessedcoolant merged 5 commits intomainfrom Aug 15, 2023
Merged
Prevent merge from crashing with a WindowsPath serialization error#4271blessedcoolant merged 5 commits intomainfrom
blessedcoolant merged 5 commits intomainfrom
Conversation
lstein
requested review from
GreggHelt2,
StAlKeR7779,
blessedcoolant,
brandonrising and
damian0815
as code owners
lstein
requested review from
Kyle0654,
maryhipp and
psychedelicious
as code owners
Collaborator
|
Wont this resolved by just passing |
Collaborator
Author
|
Oooh, I didn't know about There are actually two places where paths need to be turned into strings, one just before I'll go back and restore the call signatures to the way they were, then use |
hipsterusername
approved these changes
Aug 15, 2023
hipsterusername
force-pushed
the
bugfix/merge-crash-on-windows
branch
from
8597930 to
b2934be
Compare
blessedcoolant
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
On Windows systems, model merging was crashing at the very last step with an error related to not being able to serialize a WindowsPath object. I have converted the path that is passed to
save_pretrainedinto a string, which I believe will solve the problem.Note that I had to rebuild the web frontend and add it to the PR in order to test on my Windows VM which does not have the full node stack installed due to space limitations.
Related Tickets & Documents
https://discord.com/channels/1020123559063990373/1042475531079262378/1140680788954861698